Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhooks #4863

Merged
merged 159 commits into from
Sep 28, 2022
Merged

Add webhooks #4863

merged 159 commits into from
Sep 28, 2022

Conversation

sizov-kirill
Copy link
Contributor

@sizov-kirill sizov-kirill commented Aug 26, 2022 •
edited
Loading

Motivation and context

  • Change event naming template from <resource>_<action> to <aciton>:<resource>

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@sizov-kirill
add webhooks urls
74dd8f2
@sizov-kirill
add webhooks app in settings
6142cac
@sizov-kirill
apps/webhooks: post, get
9aa1463
@sizov-kirill
remove secret and useless fields during serialization
b6032af
@sizov-kirill
add constraint: not allow to have both project and organization id
e06e261
@sizov-kirill
add filtering and searching fields; add patch, put, delete methods
859a362
@sizov-kirill
migrations
dd55458
@sizov-kirill
rest api tests: add webhook in dump_objects
6bbed81
@sizov-kirill
webhook/apps.py: add signals in appconfig
5660395
@sizov-kirill
extend event type choice
75ad895
@sizov-kirill
add WebhookDelivery model
1cce895
@sizov-kirill
webhook: update migrations
898ec6f
@sizov-kirill
engine/mixins: override updatemodelmixin for sending signals
33c49f2
@sizov-kirill
webhooks/serializers: exclude unnecessary fields during serialization…
5929a9d 
… for instance to representation
@sizov-kirill
jobs view: use overridden mixin for sending update webhooks
4cd5e0d
@sizov-kirill
event types: delete non-existent events
13fbabe
@sizov-kirill
add signals file
2faa9df
@sizov-kirill
WebhookDelivery model: delete data, updated_data fields; add redelive…
84b3993 
…ry, changed_fields fields
@sizov-kirill
Update Webhook serializers
5ff353b
@sizov-kirill
signals: add information about sender
db15e3a
@sizov-kirill
Webhook view: pass owner info during creation, add GET webhook/{wid}/…
eb83692 
…deliveries(/{did})
@sizov-kirill
add request and response fields for WebhookDelivery model
ce5b732
@sizov-kirill
delete WebhookDeliveryWriteSerializer
0847036
@sizov-kirill
add redeliver method
a9164fc
@sizov-kirill
webhook serializer: events as a list
db157c3
@sizov-kirill
add ping event
6e6dd58
@sizov-kirill
add webhook redis queue
f656055
@sizov-kirill
add base tests
b29e3a3
@sizov-kirill
different event types for different webhook types
1b81cff
@sizov-kirill
GET available events method
90c4ddb
@sizov-kirill
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@sizov-kirill
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@nmanovic
Copy link
Contributor

@kirill-sizov , could you please fix merge conflicts?

@sizov-kirill
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

nmanovic
nmanovic approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's fix other issues in a PR with tests for webhooks.

@nmanovic nmanovic merged commit bae7564 into develop Sep 28, 2022
@nmanovic nmanovic deleted the sk/add-webhooks branch September 28, 2022 19:56
@bsekachev bsekachev mentioned this pull request Sep 29, 2022
Closed
2 tasks
@zhiltsov-max zhiltsov-max mentioned this pull request Oct 11, 2022
Merged
7 tasks
@zhiltsov-max zhiltsov-max mentioned this pull request Oct 28, 2022
Merged
7 tasks
@nmanovic nmanovic mentioned this pull request Nov 1, 2022
Closed
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsekachev bsekachev bsekachev left review comments

@klakhov klakhov klakhov left review comments

@nmanovic nmanovic nmanovic approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

Assignees
No one assigned
Labels
server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sizov-kirill @addisonklinke @nmanovic @bsekachev @klakhov